Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statetest: Extract test registration to separate function #514

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 19, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #514 (b033cbd) into master (38c5bb2) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   99.41%   99.06%   -0.36%     
==========================================
  Files          54       54              
  Lines        5318     5341      +23     
==========================================
+ Hits         5287     5291       +4     
- Misses         31       50      +19     
Flag Coverage Δ
blockchaintests 77.78% <ø> (ø)
statetests 7.49% <81.81%> (ø)
unittests 97.24% <100.00%> (-2.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/statetest/statetest.cpp 100.00% <100.00%> (+9.52%) ⬆️
test/state/state.hpp 80.00% <0.00%> (-20.00%) ⬇️
test/statetest/statetest_loader.cpp 80.86% <0.00%> (-17.03%) ⬇️

@chfast chfast force-pushed the statetest_refactor branch 2 times, most recently from 620fba4 to 9943f04 Compare October 20, 2022 10:42
@axic
Copy link
Member

axic commented Oct 20, 2022

How is this working with empty test JSONs?

@chfast
Copy link
Member Author

chfast commented Oct 20, 2022

How is this working with empty test JSONs?

The --gtest_list_tests do not execute tests (i.e. the files are not even loaded).

@chfast chfast force-pushed the statetest_refactor branch from 9943f04 to b033cbd Compare October 20, 2022 13:57
@chfast chfast merged commit 4351c41 into master Oct 20, 2022
@chfast chfast deleted the statetest_refactor branch October 20, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants